lru cache: Only send notifications to the new subscriber #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
When there's a new subscription to the cache we shouldn't notify all existing subscriptions. That causes them to receive updates even if there was no change to the SVIDs or bundles. This can cause issues with users that trigger side effects, such as restarting a service, when they receive updates on the X509 stream. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
extra-notifications
branch
from
81544fd
to
1580ace
Compare
amartinezfayo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's a new subscription to the cache we shouldn't notify all existing subscriptions. That causes them to receive updates even if there was no change to the SVIDs or bundles.
This can cause issues with users that trigger side effects, such as restarting a service, when they receive updates on the X509 stream.
I think this shouldn't be ok, I didn't see any reason for the cache notify all subscribers of a set if it knows the new subscriber already.
Pull Request check list
Which issue this PR fixes
fixes #5280